Skip to content

Conversation

@RKNF404
Copy link
Collaborator

@RKNF404 RKNF404 commented Feb 28, 2025

This will enable sandboxing on the GPU process when run under AMD hardware without Vulkan. Hardware acceleration fully works in those tested conditions.

@RKNF404 RKNF404 changed the title feat: sandbox GPU process on Linux (AMD) feat: sandbox GPU process on Linux Testing Mar 4, 2025
@RoyalOughtness RoyalOughtness added this to the 4.4.2 milestone Mar 4, 2025
@RKNF404
Copy link
Collaborator Author

RKNF404 commented Mar 4, 2025

@RoyalOughtness I've been rethinking this a bit, and it doesn't seem like good idea to just enable sandboxing like this. Especially without more comprehensive testing. I sorta transitioned this PR into more of a testing base. Since there is a lot of kinds of hardware I cannot test. I was thinking of creating an issue where users can enable the sandbox, and paste the output to the github issue.
lmk if this sounds ok.
If so, we can open the issue and this can be merged when possible.

@RoyalOughtness
Copy link
Contributor

@RoyalOughtness I've been rethinking this a bit, and it doesn't seem like good idea to just enable sandboxing like this. Especially without more comprehensive testing. I sorta transitioned this PR into more of a testing base. Since there is a lot of kinds of hardware I cannot test. I was thinking of creating an issue where users can enable the sandbox, and paste the output to the github issue. lmk if this sounds ok. If so, we can open the issue and this can be merged when possible.

makes sense, we could expose it as a flag but default it to off?

@RKNF404
Copy link
Collaborator Author

RKNF404 commented Mar 4, 2025

Yep, that's what it is now. I was going to expose the flag anyway for that purpose but I feel like more testing should be done before we all-out enable it on any hardware.

RoyalOughtness
RoyalOughtness previously approved these changes Mar 10, 2025
@RoyalOughtness RoyalOughtness merged commit 7b4d942 into secureblue:live Mar 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants