Skip to content

Conversation

@bouskaJ
Copy link
Collaborator

@bouskaJ bouskaJ commented Aug 1, 2025

Summary by Sourcery

Enforce SCC on byodb e2e test pods for OCP 4.19+ by adding a default SecurityContext to the container spec

Bug Fixes:

  • Fix failing e2e tests on OCP 4.19+ by ensuring each byodb pod complies with SCC requirements

Tests:

  • Update byodb e2e test containers to include SecurityContext settings: disable privilege escalation, drop all capabilities, run as non-root, and use the runtime default seccomp profile

Signed-off-by: Jan Bouska <jbouska@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Aug 1, 2025

Reviewer's Guide

This PR updates the BYO DB e2e test to enforce OpenShift 4.19+ SCC requirements by adding a restrictive SecurityContext to every test pod’s container spec.

File-Level Changes

Change Details Files
Enforce SecurityContext in test pod containers
  • Added SecurityContext block to container spec
  • Set AllowPrivilegeEscalation to false
  • Dropped all Linux capabilities
  • Enabled RunAsNonRoot
  • Applied SeccompProfileType RuntimeDefault
test/e2e/byodb_test.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bouskaJ - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@osmman osmman merged commit cf354d6 into main Aug 6, 2025
18 checks passed
@osmman osmman deleted the fix_e2e branch August 6, 2025 12:25
@osmman osmman added the bug Something isn't working label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants