fix: configure mysql client connection pool limits

[osmman]

Refs: SECURESIGN-2650

Summary by Sourcery

Configure MySQL client connection pool limits for both Rekor and Trillian server deployments to improve connection handling

Enhancements:

• Add max open connections, max idle connections, max connection lifetime, and max idle time flags for MySQL storage in Rekor deployment
• Introduce mysql_max_conns and mysql_max_idle_conns flags in Trillian server deployment

[sourcery-ai]

Reviewer's Guide

Introduces MySQL client connection pool limits by adding flags for max open connections, max idle connections, and connection lifetimes to the Rekor and Trillian server deployments.

Class diagram for updated MySQL client configuration in Rekor and Trillian deployments

classDiagram
    class RekorServerDeployment {
        +string[] Args
        +ensureMysqlParams()
        +--search_index.mysql.max_open_connections : int (added)
        +--search_index.mysql.max_idle_connections : int (added)
        +--search_index.mysql.conn_max_lifetime : duration (added)
        +--search_index.mysql.conn_max_idletime : duration (added)
    }
    class TrillianServerDeployment {
        +string[] Args
        +ensureDeployment()
        +--mysql_max_conns : int (added)
        +--mysql_max_idle_conns : int (added)
    }

Loading

File-Level Changes

Change	Details	Files
Rekor deployment: added MySQL connection pool flags	Added --search_index.mysql.max_open_connections flag (30) Added --search_index.mysql.max_idle_connections flag (10) Added --search_index.mysql.conn_max_lifetime flag (10m) Added --search_index.mysql.conn_max_idletime flag (2m)	internal/controller/rekor/actions/server/deployment.go
Trillian deployment: added MySQL connection pool limits	Added --mysql_max_conns=30 flag Added --mysql_max_idle_conns=10 flag	internal/controller/trillian/utils/server-deployment.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @osmman - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}