Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow dynamic (no namespace) in ArgTypes, and add a test for it #133

Conversation

@kevin-montrose
Copy link
Contributor

kevin-montrose commented Aug 14, 2019

Currently configurations expected all arguments in an ArgType to contain a namespace. This is correct except for methods taking dynamic in C# (VB.NET has no equivalent that I'm aware of).

The rest of the code seems to deal with dynamic just fine, so all this PR does is add a test and explicitly allow dynamic in Configuration.ValidateArgTypes(...).

@JarLob JarLob merged commit 67fd155 into security-code-scan:vs2017 Aug 14, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@JarLob

This comment has been minimized.

Copy link
Contributor

JarLob commented Aug 14, 2019

Thanks!

@kevin-montrose kevin-montrose deleted the kevin-montrose:vs2017-allow-dynamic-parameters branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.