Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake mode doesn't preserve window size nor position when minimize to tray is enabled #153

Closed
zakius opened this Issue Jan 9, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@zakius
Copy link

zakius commented Jan 9, 2019

Basically what title says, I'm using latest release (0.40.0) on Windows 1809

@sedwards2009

This comment has been minimized.

Copy link
Owner

sedwards2009 commented Jan 9, 2019

Is the window full size?

I've seen at least one window positioning problem on Windows which seemed to be related to full screen windows.

@zakius

This comment has been minimized.

Copy link
Author

zakius commented Jan 9, 2019

Yeah, after testing few more things it's just the maximized state that is not preserved, sorry for the confusion

@sedwards2009

This comment has been minimized.

Copy link
Owner

sedwards2009 commented Mar 12, 2019

Related to #120

@zakius

This comment has been minimized.

Copy link
Author

zakius commented Mar 25, 2019

I'm not sure if I should comment on this or open new issue but it's heavily related:

currently it may seem that maximized size is preserved but actually restored size is shown first and only then maximized back, it's clearly visible if full terminal app is running as it renders in smaller size first and then accommodates to maximized window

EDIT:

replacing

const nearestScreen = screen.getDisplayNearestPoint({x: bounds.x, y: bounds.y});
window.setSize(nearestScreen.workAreaSize.width, nearestScreen.workAreaSize.height);

with

window.maximize();

in Main.ts lines 332 and 333 does the trick for Windows, can't check how Mac reacts to that

@sedwards2009

This comment has been minimized.

Copy link
Owner

sedwards2009 commented Mar 26, 2019

I tried that out today on Windows and it seemed fine. I'll test it a bit more and also try out Linux/macOS. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.