Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird letter spacing for 0.43.0 vs 0.42.0 | Answer: Use monospace font families #206

Closed
do-kevin opened this issue Aug 18, 2019 · 19 comments

Comments

@do-kevin
Copy link

commented Aug 18, 2019

Is it just my installation or is anyone else seeing this? My font family and font size are the same between both versions.

0.43.0
0 43 0

0.42.2
0 42 2

@cobrabr

This comment has been minimized.

Copy link

commented Aug 19, 2019

Same issue here. Every time I reopen Extraterm, the font looks like the first screenshot. Also, on mine, there's a weird, thick border around the frame, which didn't use to be there before. Using it on Win10 x64. I'll grab a screenshot later at home (at work, I'm still on 0.42, exactly for those 2 reasons).

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Aug 19, 2019

@do-kevin The problem is that in a terminal you are meant to use a monospace font because all of the rows and columns of characters are supposed to line up neatly. You're using a proportional font where the width of the character varies. The bug is in the 0.42.2 screenshot. Extraterm used to assume that all characters had the same width. Since the change in how the text is drawn, that assumption is fixed.

So basically, no bug, but you should choose a monospace font, like Consolas or Dejavu sans mono.

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Aug 19, 2019

@cobrabr do post a screenshot here so that we check whether it is the same issue.

@do-kevin

This comment has been minimized.

Copy link
Author

commented Aug 19, 2019

Same issue here. Every time I reopen Extraterm, the font looks like the first screenshot. Also, on mine, there's a weird, thick border around the frame, which didn't use to be there before. Using it on Win10 x64. I'll grab a screenshot later at home (at work, I'm still on 0.42, exactly for those 2 reasons).

Could you provide a screenshot so we could see that thick border? I think it could actually be the margins.

@do-kevin The problem is that in a terminal you are meant to use a monospace font because all of the rows and columns of characters are supposed to line up neatly. You're using a proportional font where the width of the character varies. The bug is in the 0.42.2 screenshot. Extraterm used to assume that all characters had the same width. Since the change in how the text is drawn, that assumption is fixed.

So basically, no bug, but you should choose a monospace font, like Consolas or Dejavu sans mono.

Okay, I'll test it out. Thanks seward.

Update: @sedwards2009 Cool, it looks normal now with Consolas. Perhaps you should show which font families are monospace and proportionate. Or a text saying that monospace font families are best for 0.43.0 on the UI. Thanks again

@cobrabr

This comment has been minimized.

Copy link

commented Aug 19, 2019

I'll post the screenshot later, but in my case, I was already using a monospace font (tested with Oxygen Mono and Fira Code), and I had the same issue.

@cobrabr

This comment has been minimized.

Copy link

commented Aug 19, 2019

Here is the 0.42.2 screenshot (which is working fine):

image

@do-kevin do-kevin changed the title Weird letter spacing for 0.43.0 vs 0.42.0 Weird letter spacing for 0.43.0 vs 0.42.0 | Answer: Use monospace font families Aug 19, 2019

@cobrabr

This comment has been minimized.

Copy link

commented Aug 20, 2019

Here is the screenshot for 0.43:
image

Notice the font and the grey border around the frame. The configuration is the same as the one from the screenshot above.

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Aug 20, 2019

@cobrabr Thanks for that. I've seen this before on macOS but no where else until now. The background colour of the terminal itself seems to change for no reason. I'll try poking at it on Windows to see if I can find a way of reproducing this problem on demand. Then I have a chance of figuring it out.

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Aug 20, 2019

@cobrabr Looking at your screenshots, it appears that there is some tweaking to do with respect to the character spacing. It looks a bit too wide and big on the 0.43.

@cobrabr

This comment has been minimized.

Copy link

commented Aug 20, 2019

Thanks for the quick reply, @sedwards2009, I appreciate it. :)

When I change the font back to Oxygen Mono (which only lasts until I close the application; it reverts back to the font on my screenshot every time I open it), the spacing looks about the same as on 0.42.2 (i.e. it wasn't noticeable/didn't bother me). With the "weird" font, yeah, the spacing is all over the place, but I'm thinking it's the font itself more than Extraterm.

@cobrabr

This comment has been minimized.

Copy link

commented Aug 20, 2019

And now that you mention it (and looking at both screenshots), you're right, it's not the border that's the problem, it's the terminal background colour that changes incorrectly.

@do-kevin do-kevin closed this Aug 21, 2019

@cobrabr

This comment has been minimized.

Copy link

commented Aug 22, 2019

@sedwards2009, FYI 0.44 still has the same problem. Should I open a new issue for it?

@do-kevin do-kevin reopened this Aug 22, 2019

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Aug 22, 2019

@cobrabr This issue is fine. I still have to look into that Oxygen Mono problem.

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Aug 22, 2019

@cobrabr I was just able to reproduce the totally-wrong-font problem here.

Oxygen Mono looks good when it works.

sedwards2009 added a commit that referenced this issue Aug 22, 2019
@cobrabr

This comment has been minimized.

Copy link

commented Aug 22, 2019

Thanks again, @sedwards2009. Did you manage to find the reason behind the background colour changing as well?

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Sep 1, 2019

Fixed in v0.44.1.

@sedwards2009 sedwards2009 added the fixed label Sep 1, 2019

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Sep 1, 2019

@cobrabr That background color thing is on my TODO list. I've got a bunch of other little things which need attention.

@cobrabr

This comment has been minimized.

Copy link

commented Sep 2, 2019

@sedwards2009 Thanks for the heads-up. Do you need me to open a new issue for it?

Also, thanks for fixing this one! 😄

@sedwards2009

This comment has been minimized.

Copy link
Owner

commented Sep 2, 2019

@cobrabr please do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.