New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing from command in ZSH #111

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@MateuszKubuszok

MateuszKubuszok commented Aug 2, 2018

Calling from produced zsh: command not found: exfrom.py error.

After investingating PATH it appears that path began with /home/user//home/user/.extraterm-commands: instead of /home/user/.extraterm-commands:. Removing $PWD/ fixed that.

Fix for failing from command in ZSH
Calling from produced `zsh: command not found: exfrom.py` error.

After investingating `PATH` it appears that path began with `/home/user//home/user/.extraterm-commands:` instead of `/home/dev/.extraterm-commands:`. Removing `$PWD/` fixed that.
@sedwards2009

This comment has been minimized.

Show comment
Hide comment
@sedwards2009

sedwards2009 Aug 5, 2018

Owner

I'll test this a little bit more myself before merging it. I have a strong feeling that I've seen inconsistent behaviour from dirname command where it sometimes does or doesn't give absolute paths.

Owner

sedwards2009 commented Aug 5, 2018

I'll test this a little bit more myself before merging it. I have a strong feeling that I've seen inconsistent behaviour from dirname command where it sometimes does or doesn't give absolute paths.

@MateuszKubuszok

This comment has been minimized.

Show comment
Hide comment
@MateuszKubuszok

MateuszKubuszok Aug 13, 2018

I think something like ${0:a:h} could be used, it is more reliable for ZSH than dirnames and PWDs.

MateuszKubuszok commented Aug 13, 2018

I think something like ${0:a:h} could be used, it is more reliable for ZSH than dirnames and PWDs.

sedwards2009 added a commit that referenced this pull request Aug 19, 2018

When building up the $path for zsh, carefully handle a absolute or re…
…lative path.

This implements the suggestion from MateuszKubuszok in PR #111.
@sedwards2009

This comment has been minimized.

Show comment
Hide comment
@sedwards2009

sedwards2009 Aug 19, 2018

Owner

This specific PR would actually break the zsh integration on my machine here. I don't know why your set up and mine act differently. I have implemented your suggestion and it now checks for a leading slash when building up the path. This should allow it to work for both of us.

thanks for the help.

Owner

sedwards2009 commented Aug 19, 2018

This specific PR would actually break the zsh integration on my machine here. I don't know why your set up and mine act differently. I have implemented your suggestion and it now checks for a leading slash when building up the path. This should allow it to work for both of us.

thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment