Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update *.conf files to use applicable `-style` properties #23

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@darcyparker
Copy link

commented Apr 23, 2019

See #22

status-attr, window-status-fg, window-status-bg, window-status-current-fg, window-status-current-bg, pane-border-fg, pane-active-border-fg, message-bg and message-fg have been removed from tmux.

See tmux/tmux@f34ebfe

Update *.conf files to use applicable `-style` property because
`status-attr`, `window-status-fg`, `window-status-bg`, `window-status-current-fg`, `window-status-current-bg`,
`pane-border-fg`, `pane-active-border-fg`, `message-bg` and `message-fg`
have been removed from tmux.
See tmux/tmux@f34ebfe

darcyparker added a commit to darcyparker/my_dotfiles that referenced this pull request Apr 23, 2019

tlvince added a commit to tlvince/tmux-config that referenced this pull request Apr 28, 2019

@antoineco
Copy link

left a comment

I believe those could be updated as well for the sake of consistency. Tmux 2.9 doesn't complain about them, but it's just a matter of time :)

@@ -3,25 +3,24 @@
# default statusbar colors
set-option -g status-bg colour235 #base02

This comment has been minimized.

Copy link
@antoineco

antoineco Apr 29, 2019

Suggested change
set-option -g status-bg colour235 #base02
set-option -g status-style bg=colour235 #base02
@@ -3,25 +3,24 @@
# default statusbar colors
set-option -g status-bg colour235 #base02
set-option -g status-fg colour136 #yellow

This comment has been minimized.

Copy link
@antoineco

antoineco Apr 29, 2019

Suggested change
set-option -g status-fg colour136 #yellow
set-option -g status-style fg=colour136 #yellow
@darcyparker

This comment has been minimized.

Copy link
Author

commented Apr 29, 2019

@antoineco - thanks for suggestion. I made those quick changes in
fdb633f

tmuxcolors-*.conf: Be consistent and use status-style for fg and bg e…
…ven though the previous status-bg and status-fg are obsolete yet.

@darcyparker darcyparker force-pushed the darcyparker:updateOptionsRemovedFromTmux branch from 3870d07 to fdb633f Apr 29, 2019

darcyparker added a commit to darcyparker/my_dotfiles that referenced this pull request Apr 29, 2019

darcyparker added a commit to darcyparker/my_dotfiles that referenced this pull request Apr 29, 2019

@oconnor663

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

I'm noticing a difference before and after, though I'm sure what's causing it. This PR fixes the invalid option errors I was getting with the update to tmux 2.9, but the color change seems to happen regardless of whether I'm seeing errors. (My only color configuration is source-file tmuxcolors-dark.conf.) Here's the before:

image

And here's after:

image

So previously my active window was red and the rest were gray, but now everything's yellow. Is that expected?

@antoineco

This comment has been minimized.

Copy link

commented Apr 30, 2019

but now everything's yellow. Is that expected?

Nice catch, it's indeed not intended to be that way.

@darcyparker it works it you set all styles in 1 single command:

set-window-option -g window-status-current-style fg=brightred,bg=default
set-option -g status-bg colour235 #base02
set-option -g status-fg colour136 #yellow
set-option -g status-attr default
set-option -g status-style bg=colour235 #base02

This comment has been minimized.

Copy link
@antoineco

antoineco Apr 30, 2019

The second command overrides the first, parameters must be inlined:

Suggested change
set-option -g status-style bg=colour235 #base02
set-option -g status-style bg=colour235,fg=colour136 #base02,yellow
@darcyparker

This comment has been minimized.

Copy link
Author

commented Apr 30, 2019

@oconnor663 - thanks for pointing out that problem. And @antoineco - thanks for hint on how to fix it. See latest commit 7849dba.

@oconnor663

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Seems to fix the problem! Thanks for the incredibly rapid response :)

darcyparker added a commit to darcyparker/my_dotfiles that referenced this pull request Apr 30, 2019

@Xuanwo

This comment has been minimized.

Copy link

commented May 10, 2019

ping @seebi , This pr looks great for now, let's get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.