Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website & Readme.md - community feedback #303

Open
MartinKavik opened this issue Dec 3, 2019 · 19 comments
Open

Website & Readme.md - community feedback #303

MartinKavik opened this issue Dec 3, 2019 · 19 comments
Labels
docs help wanted

Comments

@MartinKavik
Copy link
Member

@MartinKavik MartinKavik commented Dec 3, 2019

Hi!
We want to make Seed's website and documentation as good as possible.

If you want to help a little bit, please see those issues for more info:

Thank you!

@MartinKavik MartinKavik added the help wanted label Dec 3, 2019
@MartinKavik MartinKavik pinned this issue Dec 3, 2019
@daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Dec 4, 2019

The docs on docs.rs aren't building for 0.5.0.

EDIT: Probably related to rust-lang/docs.rs#503.

@tiberiusferreira
Copy link
Contributor

@tiberiusferreira tiberiusferreira commented Dec 6, 2019

The website is really good! Thanks!
The only small problem is that if you switch to dark mode and refresh the page, it first renders in light mode, then switches.

@rebo
Copy link
Collaborator

@rebo rebo commented Dec 8, 2019

The new websites great, I really think because Seed is big enough and active enough that it should have an online chat presence, i.e. a Discord or something.

@flosse
Copy link
Member

@flosse flosse commented Dec 9, 2019

The new website is showing an outdated version (0.4.2 (Nov 05, 2019)) but the overall documentation is quite good :)

One thing that might be interesting for companies would be a section Commercial Support so that people can see that seed is more than just a hobby project.

@MartinKavik
Copy link
Member Author

@MartinKavik MartinKavik commented Dec 9, 2019

an online chat presence, i.e. a Discord or something

I was thinking about it, but I (we?) don't have capacity to take care of it (chat, forum, twitter, etc.) in the near future. However if you (@rebo) or anybody else want to help with it, just write us a mail :)

@MartinKavik
Copy link
Member Author

@MartinKavik MartinKavik commented Dec 9, 2019

The new website is showing an outdated version (0.4.2 (Nov 05, 2019))

Yeah, seed-rs.org content for Seed 0.5.0 is WIP (PR). We also have to redeploy docs (? @David-OConnor) to fix official Rust docs.

They are process errors, we should update docs and seed-rs.org content before the Seed release.

@MartinKavik
Copy link
Member Author

@MartinKavik MartinKavik commented Dec 9, 2019

a section Commercial Support

@flosse Could you create an issue in https://github.com/seed-rs/seed-rs.org and describe a little bit what you think that should be in this section from your point of view?

@flosse
Copy link
Member

@flosse flosse commented Dec 10, 2019

@flosse Could you create an issue in https://github.com/seed-rs/seed-rs.org and describe a little bit what you think that should be in this section from your point of view?

see seed-rs/seed-rs.org#9

@MuhannadAlrusayni
Copy link
Contributor

@MuhannadAlrusayni MuhannadAlrusayni commented Dec 10, 2019

Great job 👍 , the website is far better than the old one.

@TatriX
Copy link
Member

@TatriX TatriX commented Dec 17, 2019

I created Discord channel. Feel free to join!

@David-OConnor
Copy link
Member

@David-OConnor David-OConnor commented Dec 20, 2019

I'm getting invalid invite.

@TatriX
Copy link
Member

@TatriX TatriX commented Dec 20, 2019

It turns our that invite links have expiration date.
Here's unlimited one: https://discord.gg/JHHcHp5

@anderejd
Copy link

@anderejd anderejd commented Jan 8, 2020

I have only skimmed the new website, but it looks great! Bonus points for the dark mode button <3

@MartinKavik MartinKavik added the docs label Mar 9, 2020
@decafbad
Copy link

@decafbad decafbad commented May 1, 2020

About update function:
" It accepts a message and a model as parameters, and returns an Update struct. Update contains ShouldRender and Effect enums."
It doesn't return anything. This paragraph is either outdated or ambiguous.

@MartinKavik
Copy link
Member Author

@MartinKavik MartinKavik commented May 3, 2020

@decafbad Thanks for feedback! We plan to rewrite guides after Seed 0.7.0 release (released in next weeks). I'll try to update also docs for 0.6.0.

@flosse
Copy link
Member

@flosse flosse commented May 4, 2020

Seed 0.7.0 release (released in next weeks).

🎉 awesome!

@decafbad
Copy link

@decafbad decafbad commented Oct 23, 2020

at https://seed-rs.org/0.7.0/use/ I removed #![allow(clippy::wildcard_imports)] but no clippy errors.

@MartinKavik
Copy link
Member Author

@MartinKavik MartinKavik commented Oct 23, 2020

@decafbad Try to change something in the Rust code, save it and then run cargo make clippy. There is a bug in clippy - it sometimes doesn't lint the code at all if it's already compiled.

@decafbad
Copy link

@decafbad decafbad commented Oct 23, 2020

It works fine now, after I ran a second cargo clean. Couldn't get what's wrong.

@flosse flosse unpinned this issue Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs help wanted
Projects
None yet
Development

No branches or pull requests

10 participants