Skip to content

feat: ✨ check primary key exists #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lwjohnst86 merged 9 commits into from
Dec 8, 2025
Merged

feat: ✨ check primary key exists #218

lwjohnst86 merged 9 commits into from
Dec 8, 2025

Conversation

@martonvago
Copy link
Contributor

@martonvago martonvago commented Nov 26, 2025

Description

This PR implements the MUST constraint that primary key fields must exist (i.e. they must be fields on the same resource).

Closes #216

Needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@martonvago martonvago self-assigned this Nov 26, 2025
martonvago
martonvago commented Nov 26, 2025
View reviewed changes
martonvago
martonvago commented Nov 26, 2025
View reviewed changes
martonvago
martonvago commented Nov 26, 2025
View reviewed changes
martonvago
martonvago commented Nov 26, 2025
View reviewed changes
@martonvago martonvago moved this from Todo to In Review in Iteration planning Nov 26, 2025
@martonvago martonvago marked this pull request as ready for review November 26, 2025 16:21
@martonvago martonvago requested a review from a team as a code owner November 26, 2025 16:21
martonvago
martonvago commented Nov 27, 2025
View reviewed changes
@martonvago martonvago mentioned this pull request Nov 27, 2025
Merged
2 tasks
@martonvago martonvago mentioned this pull request Dec 1, 2025
Open
2 tasks
lwjohnst86
lwjohnst86 requested changes Dec 5, 2025
View reviewed changes
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some comments and suggested edits ☺️

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Dec 5, 2025
@martonvago martonvago moved this from In Progress to In Review in Iteration planning Dec 5, 2025
@martonvago martonvago requested a review from lwjohnst86 December 5, 2025 09:31
@martonvago
Copy link
Contributor Author

martonvago commented Dec 5, 2025

Oops, I think _keep_resources_with_no_issue_at_property is a bit broken now, moving this to in progress while I look into it

@martonvago martonvago moved this from In Review to In Progress in Iteration planning Dec 5, 2025
@martonvago martonvago moved this from In Progress to In Review in Iteration planning Dec 5, 2025
@martonvago
Copy link
Contributor Author

martonvago commented Dec 5, 2025

Okay, fixed 🎉

@lwjohnst86 lwjohnst86 merged commit de8ed07 into main Dec 8, 2025
6 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/pk-musts branch December 8, 2025 08:07
@github-project-automation github-project-automation bot moved this from In Review to Done in Iteration planning Dec 8, 2025
lwjohnst86 pushed a commit that referenced this pull request Dec 8, 2025
@martonvago
feat: ✨ check foreign keys fields exist (#227)
69d8454 
# Description

This PR checks that foreign key source and destination fields exist.
#218 should be reviewed first.

Closes #217 

Needs an in-depth review.

## Checklist

- [x] Formatted Markdown
- [x] Ran `just run-all`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwjohnst86 lwjohnst86 lwjohnst86 approved these changes

Assignees

@martonvago martonvago

Labels

None yet

Projects

Iteration planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Primary key fields must exist

3 participants

@martonvago @lwjohnst86