Skip to content

Conversation

@martonvago
Copy link
Contributor

@martonvago martonvago commented Nov 27, 2025

Description

This PR checks that foreign key source and destination fields exist.
#218 should be reviewed first.

Closes #217

Needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@martonvago martonvago moved this from Todo to In Progress in Iteration planning Nov 27, 2025
@martonvago martonvago moved this from In Progress to In Review in Iteration planning Nov 27, 2025
@martonvago martonvago marked this pull request as ready for review November 27, 2025 14:50
@martonvago martonvago requested a review from a team as a code owner November 27, 2025 14:50
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started to review this, but given my comments in #218, I'll wait until that's done since these two share such overlap.

@martonvago martonvago requested a review from lwjohnst86 December 5, 2025 10:34
lwjohnst86
lwjohnst86 previously approved these changes Dec 8, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😁

@lwjohnst86
Copy link
Member

Just need to resolve the conflicts! ☺️

@lwjohnst86 lwjohnst86 moved this from In Review to In Progress in Iteration planning Dec 8, 2025
@martonvago martonvago moved this from In Progress to In Review in Iteration planning Dec 8, 2025
@martonvago martonvago requested a review from lwjohnst86 December 8, 2025 09:57
@lwjohnst86 lwjohnst86 merged commit 69d8454 into main Dec 8, 2025
6 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/fk-musts branch December 8, 2025 11:28
@github-project-automation github-project-automation bot moved this from In Review to Done in Iteration planning Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Foreign key fields must exist

3 participants