Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TEX_SPECIAL assignment for liquids #12

Open
SirYodaJedi opened this issue Jul 11, 2024 · 0 comments
Open

Fix TEX_SPECIAL assignment for liquids #12

SirYodaJedi opened this issue Jul 11, 2024 · 0 comments

Comments

@SirYodaJedi
Copy link

When Valve changed the character that defines liquids from * to !, they left the check for assigning the TEX_SPECIAL flag as asterisk, resulting in liquids always getting 240tx subdivision and lightmaps, unlike Quake.

if (bt->name[0] == '*'

This is a bit wasteful in vanilla renderers, since they don't support lightmapped water, so the check should be changed to set the flag for ! textures as well, unless you pass a -litwater param to CSG (for use with custom renderers). I suppose * textures should still receive this flag, for consistency with vanilla behavior, but I'm not sure if that's too important (idk what happens if a non-liquid gets this flag).

(Also, the length defined for env_sky's strncasecmp should be 7, not 5.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant