Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove deprecated methods #102

Closed
seejohnrun opened this Issue · 4 comments

3 participants

@seejohnrun
Owner

No description provided.

@seejohnrun seejohnrun was assigned
@avit
Collaborator

to_hash also outputs a :start_date key. Should these be changed to :start_time for consistency?

@jessereynolds

I have the same question. When looking at the to_hash output (or to_yaml) it seems odd that we have start_date and end_time. I think consistency here would be great. But perhaps there's a reason they're different?

      {
        "start_date": "2013-01-28 08:00:00 +1030",
        "end_time": "2013-01-28 18:00:00 +1030"
      }
@seejohnrun
Owner

I think we need to move to start_time. The only reason that they're different is that end_time was added after the methods were changed.

from_yaml and from_hash still probably need to be able to deserialize start_date

@avit
Collaborator

Added IceCube.compatibility to deal with this transition; released in 0.12.0. See UPGRADING file.

@avit avit closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.