Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Rule#until should support dates #118

Closed
dlee opened this Issue · 1 comment

2 participants

@dlee

Right now, Rule#until() only supports arguments with the granularity of Time. It will accept a Date object without error, but it will naively convert it to the 00:00:00 local time of that date, which wrong.

Right now, I'm working around this by explicitly converting Date objects to Time objects that give the desired result:

(date + 1).to_time - 1

Ideally, ice_cube would properly handle Date objects for until.

@seejohnrun
Owner

Cool - great call - will have this in today

@rlivsey rlivsey referenced this issue from a commit in rlivsey/ice_cube
@seejohnrun Make #until works correctly with Date objects
Closes #118
45a6f41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.