Rule#until should support dates #118

Closed
dlee opened this Issue Nov 13, 2012 · 1 comment

Comments

Projects
None yet
2 participants

dlee commented Nov 13, 2012

Right now, Rule#until() only supports arguments with the granularity of Time. It will accept a Date object without error, but it will naively convert it to the 00:00:00 local time of that date, which wrong.

Right now, I'm working around this by explicitly converting Date objects to Time objects that give the desired result:

(date + 1).to_time - 1

Ideally, ice_cube would properly handle Date objects for until.

Owner

seejohnrun commented Nov 13, 2012

Cool - great call - will have this in today

rlivsey added a commit to rlivsey/ice_cube that referenced this issue Jun 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment