Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: Add support for icons #810

Merged
merged 3 commits into from Oct 28, 2020
Merged

List: Add support for icons #810

merged 3 commits into from Oct 28, 2020

Conversation

michaeltaranto
Copy link
Contributor

List: Add support for icons

Provides a way to use an icon for all the items in a list. When using type="icon" you must also provide the icon prop. See example below:

EXAMPLE USAGE:

<List type="icon" icon={<IconTick tone="positive" />}>
  <Text>This is a list item.</Text>
  <Text>This is a list item.</Text>
  <Text>This is a list item.</Text>
</List>

@michaeltaranto michaeltaranto requested a review from a team as a code owner October 27, 2020 23:58
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2020 •
edited

🦋 Changeset detected

Latest commit: c06c808

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

markdalgleish
markdalgleish approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 👏

Happy for you to make a judgement call about the type snapshot / props docs.

@michaeltaranto michaeltaranto merged commit 806c056 into master Oct 28, 2020
@michaeltaranto michaeltaranto deleted the list-type-icon branch October 28, 2020 03:51
@seek-oss-ci seek-oss-ci mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaeltaranto @markdalgleish