From d5c298508569ac40b33622dca1a0e90b31f4bd66 Mon Sep 17 00:00:00 2001 From: Felix Habib <33821218+felixhabib@users.noreply.github.com> Date: Fri, 8 Mar 2024 10:22:34 +1100 Subject: [PATCH] Fix reliability issues in Cypress tests for search related keyboard shortcuts (#345) --- cypress/support/utils.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/cypress/support/utils.js b/cypress/support/utils.js index 091d3686..3e2d47ff 100644 --- a/cypress/support/utils.js +++ b/cypress/support/utils.js @@ -189,18 +189,14 @@ export const loadPlayroom = (initialCode) => { }; const typeInSearchField = (text) => - /* - force true is required because cypress incorrectly and intermittently - reports that search field is covered by another element - */ - cy.get('.CodeMirror-search-field').type(text, { force: true }); + cy.get('.CodeMirror-search-field').type(text); /** * @param {string} term */ export const findInCode = (term) => { // Wait necessary to ensure code pane is focussed - cy.wait(200); // eslint-disable-line @finsit/cypress/no-unnecessary-waiting + cy.wait(500); // eslint-disable-line @finsit/cypress/no-unnecessary-waiting typeCode(`{${cmdPlus('f')}}`); typeInSearchField(`${term}{enter}`); @@ -212,7 +208,7 @@ export const findInCode = (term) => { */ export const replaceInCode = (term, replaceWith) => { // Wait necessary to ensure code pane is focussed - cy.wait(200); // eslint-disable-line @finsit/cypress/no-unnecessary-waiting + cy.wait(500); // eslint-disable-line @finsit/cypress/no-unnecessary-waiting typeCode(`{${cmdPlus('alt+f')}}`); typeInSearchField(`${term}{enter}`); if (replaceWith) { @@ -225,7 +221,7 @@ export const replaceInCode = (term, replaceWith) => { */ export const jumpToLine = (line) => { // Wait necessary to ensure code pane is focussed - cy.wait(200); // eslint-disable-line @finsit/cypress/no-unnecessary-waiting + cy.wait(500); // eslint-disable-line @finsit/cypress/no-unnecessary-waiting typeCode(`{${cmdPlus('g')}}`); typeCode(`${line}{enter}`); };