fix(deps): Migrate to react-codemirror2 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltaranto
force-pushed
the
upgrade-codemirror
branch
2 times, most recently
from
1e41851
to
39f38f4
Compare
michaeltaranto
force-pushed
the
upgrade-codemirror
branch
from
95e3388
to
d6f8e94
Compare
michaeltaranto
commented
Jul 23, 2019
| cache: | ||
| yarn: true | ||
| directories: | ||
| - ~/.cache/Cypress |
There was a problem hiding this comment.
See cypress docs
michaeltaranto
commented
Jul 23, 2019
| {} | ||
| { | ||
| "defaultCommandTimeout": 10000, | ||
| "video": false |
There was a problem hiding this comment.
Disabling video as we dont publish the assets anywhere so its a waste. Also bumping the timeout as the execution time was inconsistent.
| frames={frames} | ||
| frameComponent={frameComponent} | ||
| /> | ||
| <Preview code={renderCode} themes={themes} frames={frames} /> |
There was a problem hiding this comment.
Why are frameComponent and components not passed anymore?
There was a problem hiding this comment.
They are unused.
markdalgleish
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates from
react-codemirrortoreact-codemirror2.Also upgrading cypress and switching CI over to
yarnso it honours the lock file.Closes #32.