Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compile with babel/standalone instead of buble #135

Merged
merged 4 commits into from Mar 12, 2020

Conversation

@michaeltaranto
Copy link
Contributor

michaeltaranto commented Mar 11, 2020

Bug fixes

  • Allow props spreading alongside inline props

Fixes #118

Copy link
Member

markdalgleish left a comment

One comment around leftover types for Bublé, but otherwise looks good 👍

@@ -62,6 +62,7 @@
"@babel/preset-env": "^7.8.3",
"@babel/preset-react": "^7.8.3",
"@babel/preset-typescript": "^7.8.3",
"@babel/standalone": "^7.8.7",
"@types/base64-url": "^2.2.0",
"@types/buble": "^0.19.2",

This comment has been minimized.

Copy link
@markdalgleish

markdalgleish Mar 12, 2020

Member

Need to remove this too.

@michaeltaranto michaeltaranto merged commit ebb796b into master Mar 12, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.