Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Handle build errors #20

Merged
merged 2 commits into from Nov 23, 2018

Conversation

@markdalgleish
Copy link
Member

commented Nov 23, 2018

This fixes two issues with playroom build:

  • In the case of an error, it wasn't being logged to the terminal.
  • Only errors with webpack itself were being caught, not errors with the code being compiled. For example, a syntax error in your component library wouldn't fail the build.
@jackhurley23
Copy link
Contributor

left a comment

Look's good 👍

@markdalgleish markdalgleish merged commit 0f293a1 into master Nov 23, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pullapprove 1 group approved
Details

@markdalgleish markdalgleish deleted the handle-build-errors branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.