Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Migrate to react-codemirror2 #75

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@michaeltaranto
Copy link
Contributor

commented Jul 23, 2019

Migrates from react-codemirror to react-codemirror2.

Also upgrading cypress and switching CI over to yarn so it honours the lock file.

Closes #32.

@michaeltaranto michaeltaranto force-pushed the upgrade-codemirror branch 2 times, most recently from 1e41851 to 39f38f4 Jul 23, 2019

@michaeltaranto michaeltaranto force-pushed the upgrade-codemirror branch from 95e3388 to d6f8e94 Jul 23, 2019

cache:
yarn: true
directories:
- ~/.cache/Cypress

This comment has been minimized.

Copy link
@michaeltaranto
{}
{
"defaultCommandTimeout": 10000,
"video": false

This comment has been minimized.

Copy link
@michaeltaranto

michaeltaranto Jul 23, 2019

Author Contributor

Disabling video as we dont publish the assets anywhere so its a waste. Also bumping the timeout as the execution time was inconsistent.

frames={frames}
frameComponent={frameComponent}
/>
<Preview code={renderCode} themes={themes} frames={frames} />

This comment has been minimized.

Copy link
@mattsjones

mattsjones Jul 23, 2019

Why are frameComponent and components not passed anymore?

This comment has been minimized.

Copy link
@michaeltaranto

michaeltaranto Jul 23, 2019

Author Contributor

They are unused.

@markdalgleish
Copy link
Member

left a comment

Nice one. Thanks heaps for doing this 👏

@michaeltaranto michaeltaranto merged commit fa28632 into master Jul 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@michaeltaranto michaeltaranto deleted the upgrade-codemirror branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.