Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve prettier formatting error #77

Merged
merged 5 commits into from Jul 29, 2019

Conversation

@michaeltaranto
Copy link
Contributor

commented Jul 25, 2019

Fixes the prettier formatting bug introduced in the CodeMirror upgrade, plus adding a cypress test to cover the formatting scenario.

(Also upgrading lodash to get rid of the vulnerability warning)

Closes #76

@michaeltaranto michaeltaranto force-pushed the fix-format-cmd branch from 0b3b10a to b3fcce3 Jul 25, 2019

@markdalgleish

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Nice work adding a test for this 👏

michaeltaranto added some commits Jul 29, 2019

@michaeltaranto michaeltaranto merged commit b5eb346 into master Jul 29, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@michaeltaranto michaeltaranto deleted the fix-format-cmd branch Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.