From 95e64302d7a3b511afd66fe80b31f47df5f00931 Mon Sep 17 00:00:00 2001
From: Adam Skoufis <askoufis@seek.com.au>
Date: Tue, 7 May 2024 10:29:34 +1000
Subject: [PATCH] Un-hoist some packages, clean up lockfile after `sku init`
 test

---
 .npmrc                 |  7 -------
 tests/sku-init.test.js | 20 +++++++++++++++++---
 2 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/.npmrc b/.npmrc
index 7e297afb5..1fe293379 100644
--- a/.npmrc
+++ b/.npmrc
@@ -2,14 +2,7 @@
 public-hoist-pattern[]="*eslint*"
 public-hoist-pattern[]="*prettier*"
 
-# `sku` itself needs these to be hoisted
-public-hoist-pattern[]="babel-loader"
-public-hoist-pattern[]="css-loader"
-
 # This is only necessary in this repo because pnpm symlinks the sku dependency in fixtures to the sku package folder directly
 # This bypasses the .pnpm folder that resolveModules looks for
 # See https://github.com/seek-oss/sku/blob/275752bd3066e52885d461ef5bcd953aaac3bfff/config/webpack/resolveModules.js
 public-hoist-pattern[]="@babel/*"
-
-# Ensure that the same TypeScript version used by sku is used by the monorepo
-public-hoist-pattern[]="typescript"
diff --git a/tests/sku-init.test.js b/tests/sku-init.test.js
index 23b9bf97b..0a8952f68 100644
--- a/tests/sku-init.test.js
+++ b/tests/sku-init.test.js
@@ -4,14 +4,28 @@ const { rimraf } = require('rimraf');
 const { runSkuScriptInDir } = require('@sku-private/test-utils');
 
 const fixtureDirectory = path.join(__dirname, '../fixtures/sku-init');
+const { promisify } = require('node:util');
+const exec = promisify(require('node:child_process').exec);
 
 describe('sku init', () => {
+  const projectName = 'new-project';
+
+  beforeAll(async () => {
+    await rimraf(path.join(fixtureDirectory, projectName));
+  });
+
+  afterAll(async () => {
+    await rimraf(path.join(fixtureDirectory, projectName));
+
+    console.log(
+      "Running 'pnpm install' to clean lockfile up after sku-init test...",
+    );
+    await exec('pnpm install');
+  });
+
   it(
     'should create a sku.config.ts',
     async () => {
-      const projectName = 'new-project';
-      await rimraf(path.join(fixtureDirectory, projectName));
-
       const { child } = await runSkuScriptInDir('init', fixtureDirectory, [
         projectName,
       ]);