From 09697680581a1def469171b69d1c29497c2ddc5c Mon Sep 17 00:00:00 2001 From: Sam Chung Date: Thu, 8 Feb 2024 09:44:28 +1100 Subject: [PATCH] Ignore specific sections in deep-dive (#1438) --- .prettierignore | 2 -- docs/deep-dives/pnpm.md | 5 +++++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.prettierignore b/.prettierignore index 7c3a17ad7..2cb55dbe6 100644 --- a/.prettierignore +++ b/.prettierignore @@ -9,5 +9,3 @@ pnpm-lock.yaml /integration/base/ -# TODO: figure out a better formatting system -docs/deep-dives/pnpm.md diff --git a/docs/deep-dives/pnpm.md b/docs/deep-dives/pnpm.md index 5b5caeef8..f06944868 100644 --- a/docs/deep-dives/pnpm.md +++ b/docs/deep-dives/pnpm.md @@ -206,6 +206,7 @@ This migration guide assumes that your project was scaffolded with a **skuba** t Your build pipeline may have previously mounted an ephemeral `.npmrc` with an auth token at `/workdir`. This needs to be mounted elsewhere to avoid overwriting the new pnpm configuration stored in `.npmrc`. + ```diff FROM --platform=${BUILDPLATFORM:-<%- platformName %>} node:20-alpine AS dev-deps @@ -225,6 +226,7 @@ This migration guide assumes that your project was scaffolded with a **skuba** t + pnpm fetch ``` + Move the `dst` of the ephemeral `.npmrc` from `/workdir/.npmrc` to `/root/.npmrc`, and use a [bind mount] in place of `COPY` to mount `pnpm-lock.yaml`. @@ -243,6 +245,7 @@ This migration guide assumes that your project was scaffolded with a **skuba** t Swap out `yarn` commands for `pnpm` commands, and drop the unnecessary `AS deps` stage. + ```diff - FROM ${BASE_IMAGE} AS deps - @@ -272,6 +275,8 @@ This migration guide assumes that your project was scaffolded with a **skuba** t ENV NODE_ENV=production ``` + + 15. Modify plugins in `.buildkite/pipeline.yml` Your build pipeline may have previously output an ephemeral `.npmrc` with an auth token on the build agent.