Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The magnify icon to explore a data file (individual file) incorrectly says its not supported #170

Open
stuzart opened this issue Feb 14, 2020 · 1 comment
Assignees

Comments

@stuzart
Copy link
Member

@stuzart stuzart commented Feb 14, 2020

If there is a data file which can be explored, there is also a magnifying glass icon next to the individual file which in previous versions also allowed you to explore. Now that icon has a tooltip saying the filetype is unsupported.

@stuzart stuzart added this to To do in SEEK 1.10.0 remaining Feb 14, 2020
@stuzart stuzart moved this from To do to In progress in SEEK 1.10.0 remaining Feb 17, 2020
@stuzart stuzart self-assigned this Feb 17, 2020
@stuzart stuzart moved this from In progress to To do in SEEK 1.10.0 remaining Feb 17, 2020
@stuzart

This comment has been minimized.

Copy link
Member Author

@stuzart stuzart commented Feb 17, 2020

This affects the previous version (so isn't a new bug) and is not straightforward to fix - as the spreadsheet "explore" is done at the data file level rather than the content blob.

stuzart added a commit that referenced this issue Feb 17, 2020
if view content isn't available, show the magnifier icon in a disabled
state, but override the pointer-events to allow clicks
@stuzart stuzart closed this Feb 17, 2020
@stuzart stuzart removed this from To do in SEEK 1.10.0 remaining Feb 17, 2020
@stuzart stuzart reopened this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.