Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on Workflow RO Crate spec #183

Open
fbacall opened this issue Mar 6, 2020 · 5 comments
Open

Comments on Workflow RO Crate spec #183

fbacall opened this issue Mar 6, 2020 · 5 comments
Labels

Comments

@fbacall
Copy link
Contributor

@fbacall fbacall commented Mar 6, 2020

@fbacall fbacall added the workflowhub label Mar 6, 2020
@stain

This comment has been minimized.

Copy link
Contributor

@stain stain commented Mar 17, 2020

It was somewhat agreed to move that document to the wiki https://github.com/workflowhub-eu/about/wiki/Workflow-RO-Crate

@stuzart

This comment has been minimized.

Copy link
Member

@stuzart stuzart commented Mar 17, 2020

The relationship with the BioSchemaWorkflow specification (also being developed) isn't explicitly mentioned, and may be unclear to anybody unfamiliar with it.

@jmfernandez

This comment has been minimized.

Copy link

@jmfernandez jmfernandez commented Mar 18, 2020

Hi, I'm missing an example of a workflow with a subjectOf, showing both an abstract CWL workflow and a concrete implementation (CWL, Nextflow, etc...)

@jmfernandez

This comment has been minimized.

Copy link

@jmfernandez jmfernandez commented Mar 18, 2020

Also, I'm missing some mention about whether the input, output and parameter names of the abstract CWL and concrete implementation workflows should match. I guess the the inputs and outputs in abstract CWL are going to have the needed ontological annotations (for instance, from EDAM), as it is not assured the concrete implementation workflow format is able to document it properly.

@jmfernandez

This comment has been minimized.

Copy link

@jmfernandez jmfernandez commented Mar 18, 2020

Last, some workflows in the wild usually include some accessory / optional initialization tasks to download and/or format reference databases, in order to work properly. Should the spec document that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.