Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "opendrop" package for pip installation #8

Closed
bf opened this issue Aug 19, 2019 · 6 comments

Comments

@bf
Copy link

commented Aug 19, 2019

Currently the command pip3 install opendrop shows that the package is not registered in the PIP repositories yet, therefore it is easy for someone malicious to claim the package and serve arbitrary code with it.

I suggest the maintainers of this project register it with PIP so it can be installed with above-mentioned command.

@SEJeff

This comment has been minimized.

Copy link

commented Aug 19, 2019

This would require sending the changes to python-zeroconf back upstream first.

@jsjohnst

This comment has been minimized.

Copy link

commented Aug 19, 2019

@SEJeff I would still recommend putting a placeholder package up for the reasons indicated by @bf. If you don't, someone else will.

@SEJeff

This comment has been minimized.

Copy link

commented Aug 19, 2019

@jsjohnst agreed, but a placeholder, not the full version.

@schmittner

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Thanks @bf, that's a valid concern.

I've created a placeholder project at pypi.org. I'll publish releases there if the projects becomes more mature.

@jstasiak

This comment has been minimized.

Copy link

commented Aug 19, 2019

This would require sending the changes to python-zeroconf back upstream first.

I don't think it's required strictly speaking, but I'd be interested in having the changes upstream regardless. :)

Note that there's been some work on IPv6 (notably jstasiak/python-zeroconf#174) so there may be some clash here as the readme says

We use a modified version of the python-zeroconf package (essentially adding rudimentary IPv6 and AWDL support)

I'm sure we'll work something out though.

PS. Nice project!

@schmittner schmittner referenced this issue Aug 20, 2019
0 of 2 tasks complete
schmittner added a commit that referenced this issue Aug 21, 2019
@schmittner

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

The package is available at https://pypi.org/project/opendrop/

@schmittner schmittner closed this Aug 21, 2019

schmittner added a commit that referenced this issue Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.