Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

split google analytics in two: classic and universal #64

Closed
reinpk opened this Issue Mar 5, 2014 · 1 comment

Comments

Projects
None yet
1 participant
Contributor

reinpk commented Mar 5, 2014

This would allow people to run Classic alongside Universal, and clean up the code/interface since some of the options are only available for Classic.

Currently we have a big switch between the two:
https://github.com/segmentio/analytics.js-integrations/blob/master/lib/google-analytics.js#L52-L65

Would be nicer to have a separate google-analytics-universal.js and google-analytics-classic.js for each version. It'll make it nice and easy to deprecate classic down the road too.

@reinpk reinpk added the enhancement label Mar 5, 2014

Contributor

reinpk commented Apr 7, 2014

now that google analytics universal just got feature parity, i think having them in one integration will be much less confusing, so closing this as unnecessary! thanks ga!

http://analytics.blogspot.com/2014/04/universal-analytics-out-of-beta-into.html

@reinpk reinpk closed this Apr 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment