Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -beta suffix from CFBundleShortVersionString #795

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
2 participants
@eliperkins
Copy link
Contributor

eliperkins commented Oct 15, 2018

What does this PR do?

This allows for the framework to be used in Swift 4 projects who consume this framework from Carthage, to be submitted to the App Store.

Closes #794

Where should the reviewer start?

By reading #794

How should this be manually tested?

Create a project with Swift 4, consume this framework with Carthage, and then submit it to the App Store 馃槄

Any background context you want to provide?

#794

What are the relevant tickets?

#794

Remove -beta suffix from CFBundleShortVersionString
This allows for the framework to be used in projects submitted to the App Store.

Closes #794
@eliperkins

This comment has been minimized.

Copy link
Contributor Author

eliperkins commented Oct 15, 2018

Alternatively, releasing 3.7.0 will fix #794 but that's beyond the scope of what I can submit a PR for 馃槄

@fathyb

fathyb approved these changes Oct 22, 2018

Copy link
Member

fathyb left a comment

LGTM, we will release beta.1 shortly. Thanks!

@fathyb fathyb merged commit 97c2674 into segmentio:master Oct 22, 2018

@eliperkins eliperkins deleted the eliperkins:patch/794 branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.