Run linter #109
Merged
Run linter #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, did the linter catch any errors? |
|
There's no error now. |
f2prateek
pushed a commit
that referenced
this pull request
Mar 6, 2018
* Enable code coverage and output report to coverage_report folder * Remove --colors option in .travis.yml which is enabled in phpunit.xml * Upload coverage result to codecov.io * Add Linter to CI (#109) * Run php linter before unit testing * Install phplint before execute scripts * Execute phplint when the php version is above or equal 5.5 * Run composer install when the php version is 5.5 or later * Fix bash script error * Fix bash script error in conditional expression * Enable code coverage and output report to coverage_report folder * Remove --colors option in .travis.yml which is enabled in phpunit.xml * Upload coverage result to codecov.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP linter is not working with older version of PHP (< v5.5)