From 5792aeda4356ca48db8301a0b7a7791271db7649 Mon Sep 17 00:00:00 2001 From: Nitish Mittal Date: Wed, 22 Sep 2021 13:45:54 +0530 Subject: [PATCH 1/2] fix(vwo-settings): updated variable name for track only AB experiments setting --- integrations/visual-website-optimizer/lib/index.js | 14 +++++++------- integrations/visual-website-optimizer/package.json | 2 +- .../visual-website-optimizer/test/index.test.js | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/integrations/visual-website-optimizer/lib/index.js b/integrations/visual-website-optimizer/lib/index.js index da5b4d718..12fb02598 100644 --- a/integrations/visual-website-optimizer/lib/index.js +++ b/integrations/visual-website-optimizer/lib/index.js @@ -29,7 +29,7 @@ var VWO = (module.exports = integration('Visual Website Optimizer') .option('listen', false) .option('experimentNonInteraction', false) .option('isSpa', false) - .option('trackOnlyABExperiments', false)); + .option('trackOnlyAbExperiments', false)); /** * The context for this integration. @@ -135,7 +135,7 @@ VWO.prototype.roots = function() { context: { integration: integrationContext } }); }); - }, this.options.trackOnlyABExperiments); + }, this.options.trackOnlyAbExperiments); }; /** @@ -147,13 +147,13 @@ VWO.prototype.roots = function() { * @return {Object} */ -function rootExperiments(fn, trackOnlyABExperiments) { +function rootExperiments(fn, trackOnlyAbExperiments) { enqueue(function() { var data = {}; var experimentIds = window._vwo_exp_ids; if (!experimentIds) return fn(); each(experimentIds, function(experimentId) { - var variationName = variation(experimentId, trackOnlyABExperiments); + var variationName = variation(experimentId, trackOnlyAbExperiments); if (variationName) data[experimentId] = variationName; }); fn(null, data); @@ -215,7 +215,7 @@ function isValidExperimentType(experiment) { * @return {String} */ -function variation(id, trackOnlyABExperiments) { +function variation(id, trackOnlyAbExperiments) { var experiments = window._vwo_exp; if (!experiments) return null; var experiment = experiments[id]; @@ -227,8 +227,8 @@ function variation(id, trackOnlyABExperiments) { } if ( - trackOnlyABExperiments && - !isValidExperimentType(experiment, trackOnlyABExperiments) + trackOnlyAbExperiments && + !isValidExperimentType(experiment, trackOnlyAbExperiments) ) { return null; } diff --git a/integrations/visual-website-optimizer/package.json b/integrations/visual-website-optimizer/package.json index 09493966f..e4a08baa8 100644 --- a/integrations/visual-website-optimizer/package.json +++ b/integrations/visual-website-optimizer/package.json @@ -1,7 +1,7 @@ { "name": "@segment/analytics.js-integration-visual-website-optimizer", "description": "The Visual Website Optimizer analytics.js integration.", - "version": "2.4.3", + "version": "2.4.4", "keywords": [ "analytics.js", "analytics.js-integration", diff --git a/integrations/visual-website-optimizer/test/index.test.js b/integrations/visual-website-optimizer/test/index.test.js index 421ff8af2..9cff68b1a 100644 --- a/integrations/visual-website-optimizer/test/index.test.js +++ b/integrations/visual-website-optimizer/test/index.test.js @@ -262,9 +262,9 @@ describe('Visual Website Optimizer', function() { }); }); - it('should not send experiments if experiment type is not of type A/B with trackOnlyABExperiments enabled', function(done) { + it('should not send experiments if experiment type is not of type A/B with trackOnlyAbExperiments enabled', function(done) { vwo.options.listen = true; - vwo.options.trackOnlyABExperiments = true; + vwo.options.trackOnlyAbExperiments = true; window._vwo_exp[1].type = 'testType'; analytics.initialize(); analytics.page(); @@ -292,7 +292,7 @@ describe('Visual Website Optimizer', function() { }); }); - it('should send experiments if experiment type is not of type A/B with trackOnlyABExperiments disabled', function(done) { + it('should send experiments if experiment type is not of type A/B with trackOnlyAbExperiments disabled', function(done) { vwo.options.listen = true; window._vwo_exp[1].type = 'testType'; analytics.initialize(); From b93dd1b173719ceb27d2f6f76650d0eb24acc9f9 Mon Sep 17 00:00:00 2001 From: Nitish Mittal Date: Wed, 22 Sep 2021 13:51:41 +0530 Subject: [PATCH 2/2] fix(vwo-setting): reverted the package.json change --- integrations/visual-website-optimizer/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integrations/visual-website-optimizer/package.json b/integrations/visual-website-optimizer/package.json index e4a08baa8..09493966f 100644 --- a/integrations/visual-website-optimizer/package.json +++ b/integrations/visual-website-optimizer/package.json @@ -1,7 +1,7 @@ { "name": "@segment/analytics.js-integration-visual-website-optimizer", "description": "The Visual Website Optimizer analytics.js integration.", - "version": "2.4.4", + "version": "2.4.3", "keywords": [ "analytics.js", "analytics.js-integration",