Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip not applying custom "className" property #666

Closed
tohjustin opened this issue Nov 2, 2019 · 0 comments · Fixed by #667
Closed

Tooltip not applying custom "className" property #666

tohjustin opened this issue Nov 2, 2019 · 0 comments · Fixed by #667

Comments

@tohjustin
Copy link
Contributor

@tohjustin tohjustin commented Nov 2, 2019

Description

<Tooltip /> allows user to specify properties passed through to the tooltip via the statelessProps prop.

However since v4.21.0, the component doesn't seem to be handling the className property correctly (i.e. className property passed to props.statelessProps isn't being applied to the Tooltip component)

Cause

This bug seems to be introduced in be35cad#diff-484772c4ad03c20c8d908b4c643e0b9aR215 where the component references statelessProps.classNames instead of statelessProps.className (the former is an invalid property).

Proposed Solution

Modify src/tooltip/src/Tooltip.js to use statelessProps.className instead

tohjustin added a commit to tohjustin/evergreen that referenced this issue Nov 2, 2019
@tohjustin tohjustin changed the title Tooltip not applying "className" property passed to `props.statelessProps` Tooltip not applying custom "className" property Nov 2, 2019
@mshwery mshwery closed this in #667 Nov 2, 2019
mshwery added a commit that referenced this issue Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.