Fforres/fix warnings #145
Merged
Fforres/fix warnings #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroenransijn
approved these changes
Mar 1, 2018
Contributor
jeroenransijn
left a comment
jeroenransijn
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the fix. Sorry for the late review 😞
Contributor
Author
|
:D Np |
prateekgoel
pushed a commit
to prateekgoel/evergreen
that referenced
this pull request
Oct 26, 2018
* Adding proper proptype vlidation * adding watch mode for build * Adding default appearance for icon on combobox * Fixing newutral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #143 I added the wrong proptype validations so this PR fixes it
Also, while using comboBox on our app, I'm getting a warning for
So this PR defines a defaultProp for
<IconButton/>to be passed onto the<Button/>and allows overwriting it on<ComboBox/>