Skip to content

Conversation

@sirwart
Copy link
Contributor

@sirwart sirwart commented Dec 7, 2018

No description provided.

@tejasmanohar
Copy link
Contributor

tejasmanohar commented Dec 8, 2018

float64 is a little questionable for decimal type but can't do better in stdlib afaik (I think the postgres driver I use, jackc/pgx, does same). If someone needs it later, I suppose they could send a PR using the de facto decimal library (shopspring/decimal)

I love how your PRs have tests and are ready to merge! Thanks

@tejasmanohar tejasmanohar merged commit dfa5f18 into segmentio:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants