Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddPartitionsToTnx to Client. #736

Merged
merged 1 commit into from Sep 14, 2021

Conversation

rhansen2
Copy link
Collaborator

@rhansen2 rhansen2 commented Sep 13, 2021

Implement AddPartitionsToTxn function for kafka.Client

Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! 👏

Comment on lines +82 to +84
{
Partition: 0,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know Go allowed to omit sub-types in struct literals now!

@rhansen2 rhansen2 merged commit a63af32 into segmentio:master Sep 14, 2021
@rhansen2 rhansen2 deleted the addpartitionstotxn branch September 14, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants