Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support saslAuthenticate v0 in protocol package #869

Merged
merged 1 commit into from Apr 1, 2022

Conversation

rhansen2
Copy link
Collaborator

Potentially related to #868 and #795

@rhansen2 rhansen2 force-pushed the transport-saslv0 branch 2 times, most recently from 983014e to 52c3d81 Compare March 20, 2022 05:36
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there documentation you found that explains how v0 and v1 SASL messages differ?

@rhansen2
Copy link
Collaborator Author

The differences are documented here: https://kafka.apache.org/protocol#sasl_handshake (although I found the issue by comparing dialer network traffic to transport network traffic >.<)

@Jrmy2402
Copy link

When do you think you can merge this PR? I wait for it with impatience :)

@rhansen2 rhansen2 merged commit 4296f73 into segmentio:main Apr 1, 2022
@rhansen2 rhansen2 deleted the transport-saslv0 branch April 1, 2022 18:59
@rhansen2
Copy link
Collaborator Author

rhansen2 commented Apr 1, 2022

@Jrmy2402 This fix is now included in https://github.com/segmentio/kafka-go/releases/tag/v0.4.31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants