Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logger example #871

Merged
merged 1 commit into from Mar 22, 2022
Merged

Fix logger example #871

merged 1 commit into from Mar 22, 2022

Conversation

route
Copy link
Contributor

@route route commented Mar 22, 2022

Since msg is formatted we should call Printf because Println doesn't support variadic arguments

Since `msg` is formatted we should call `Printf` because `Println` doesn't support variadic arguments
Copy link
Collaborator

@rhansen2 rhansen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@rhansen2 rhansen2 merged commit 6b6b5bd into segmentio:main Mar 22, 2022
@route route deleted the patch-1 branch March 23, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants