Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceHash balancer #906

Merged
merged 4 commits into from May 20, 2022
Merged

ReferenceHash balancer #906

merged 4 commits into from May 20, 2022

Conversation

fracasula
Copy link
Contributor

Hey guys, can I have some feedback on this PR please?

I've opened it due to this issue.

@rhansen2
Copy link
Collaborator

HI @fracasula,

Thanks for the contribution.

Overall this looks good to me.

Could you also update the compatibility section of the README to mention this balancer?

Thanks!

@fracasula
Copy link
Contributor Author

Could you also update the compatibility section of the README to mention this balancer?

There you go @rhansen2 (commit) 🙂

@rhansen2
Copy link
Collaborator

Thanks @fracasula!

Unfortunately I can't merge until the checks all pass. I think you just need to rebase to the tip of main so you have this commit in your branch.

@fracasula
Copy link
Contributor Author

Unfortunately I can't merge until the checks all pass. I think you just need to rebase to the tip of main so you have this commit in your branch.

@rhansen2 I rebased and that commit is included now. However one test is still failing but it's not related to this PR.

This is the failing test:

--- FAIL: TestReaderReadCompactedMessage (125.08s)

Full log here.

I can't re-run the build either so what do you suggest we do?

@fracasula
Copy link
Contributor Author

Did you re-run this one? It looks like the build is finally green 👍

@rhansen2
Copy link
Collaborator

Yup it looked like just a transient timeout.

@rhansen2 rhansen2 merged commit efb57af into segmentio:main May 20, 2022
@fracasula fracasula deleted the referenceHash branch June 10, 2022 12:37
@fracasula fracasula restored the referenceHash branch June 10, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants