Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add golangci-lint to circleci config #907

Merged
merged 12 commits into from May 16, 2022
Merged

Conversation

dominicbarnes
Copy link
Contributor

This PR adds golangci-lint to our CircleCI configuration. The main intent is to fix #877 but it appears like many other subtle bugs could be uncovered with this extensive of a linting tool.

Once the initial run happens, we'll have a sense for how many errors there are to fix.

@dominicbarnes dominicbarnes force-pushed the golangci-lint branch 10 times, most recently from 6574b2a to 7f45429 Compare May 13, 2022 16:43
@dominicbarnes dominicbarnes merged commit cc6b7a1 into main May 16, 2022
@dominicbarnes dominicbarnes deleted the golangci-lint branch May 16, 2022 05:52
fracasula pushed a commit to fracasula/kafka-go that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add static checker to ensure that we use errors.Is
2 participants