Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable errorlint linter and fix issues #914

Merged
merged 2 commits into from May 20, 2022
Merged

Conversation

dominicbarnes
Copy link
Contributor

@dominicbarnes dominicbarnes commented May 16, 2022

This PR enables the errorlint linter in golangci-lint. This specifically ensures that errors are properly checked, avoiding things like direct equality (==) checks and type coercion/switch, to ensure as much compatibility with improvements to errors in go 1.13+.

This is a continuation of #877, but will need to be followed up by one more PR to enable another linter to ensure we wrap errors coming from external packages.

consumergroup.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@rhansen2 rhansen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominicbarnes dominicbarnes merged commit 294fbdb into main May 20, 2022
@dominicbarnes dominicbarnes deleted the moar-error-handling branch May 20, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants