Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle error in response #925

Merged
merged 3 commits into from Jun 3, 2022

Conversation

rhansen2
Copy link
Collaborator

@rhansen2 rhansen2 commented Jun 3, 2022

While using this in production we ran into a panic where DescribeConfigs resulted in a *net.OpError (due to the kafka cluster rebalancing).

The panic was because we cast everything to *Response even though there are cases where it's an error. Handling this case with an error type seemed more appropriate.

This is a recreation of #890 which maintains the original authors commits.

@rhansen2 rhansen2 force-pushed the cyx-fix-handle-error-in-response branch from ad5ec34 to 2cdf54a Compare June 3, 2022 15:50
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Thanks for the fix!

@achille-roussel achille-roussel self-assigned this Jun 3, 2022
@rhansen2 rhansen2 merged commit e7c2c10 into segmentio:main Jun 3, 2022
@rhansen2 rhansen2 deleted the cyx-fix-handle-error-in-response branch June 3, 2022 16:17
@dmarkhas
Copy link
Contributor

Guys the same issue happens in all other request... (we are seeing it in ListGroups).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants