Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add consumer group apis to client #943

Merged
merged 4 commits into from Jul 4, 2022

Conversation

rhansen2
Copy link
Collaborator

@rhansen2 rhansen2 commented Jul 2, 2022

JoinGroup,SyncGroup,LeaveGroup

JoinGroup,SyncGroup,LeaveGroup
@rhansen2 rhansen2 marked this pull request as ready for review July 2, 2022 22:00
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great 🙌 Thanks for adding support for these APIs!

leavegroup.go Outdated
Comment on lines 93 to 99
res.Members = []LeaveGroupResponseMember{
{
ID: req.Members[0].ID,
GroupInstanceID: req.Members[0].GroupInstanceID,
},
}
return res, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way to make this a bit less of a special case would be to assign r.Members instead of res.Members, and let the code carry on with the regular path. That way we always take the code path below even when dealing with older API versions.

Just a suggestion, feel free to leave it as-is if you think it's more readable.

@rhansen2 rhansen2 merged commit f0d5443 into segmentio:main Jul 4, 2022
@rhansen2 rhansen2 deleted the client-group-api branch July 4, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants