Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Destination Filters device-mode support #6144

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

PcooperSegment
Copy link
Contributor

Proposed changes

Adjusting the line for mobile device mode libraries. The older libraries such as IOS and Android don't have support for destination filters.

Swift and Kotlin do have destination filter support.

Merge timing

  • ASAP once approved

Adjusting the line for mobile device mode libraries. The older libraries such as IOS and Android don't have support for destination filters. 

Swift and Kotlin do have destination filter support.
Copy link
Contributor

@niallzato niallzato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change to the following:

- *(For IOS and Android mobile device-mode)* Destination filters are currently not supported. Our Swift, Kotlin and React Native libraries do support device-mode destination filters.

@PcooperSegment PcooperSegment marked this pull request as ready for review March 8, 2024 14:32
@PcooperSegment PcooperSegment requested a review from a team as a code owner March 8, 2024 14:32
@PcooperSegment PcooperSegment requested review from pwseg and removed request for a team March 8, 2024 14:32
@pwseg pwseg changed the title Update destination-filters.md Update Destination Filters device-mode support Mar 14, 2024
@pwseg pwseg merged commit 84c639d into develop Mar 14, 2024
3 checks passed
@pwseg pwseg deleted the PcooperSegment-patch-1 branch March 14, 2024 17:18
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

@pwseg pwseg added the content-update updates to content that are not new features, includes grammar fixes, added notes label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes KCS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants