Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Translation fixes #105

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

cuchac commented Jul 29, 2012

This pull request fixes two translation issues.

  1. Allows translation of "Upload a file" button and "Drop files here to upload" message present on upload page
  2. Uses lazy variant of ugettext to avoid early initialization of translation machinery that can cause load of all apps and modules
Owner

sehmaschine commented Jul 31, 2012

about the translations: you didn´t update the original po-file, right?
about ugettext_lazy: why only with actions.py and not in other places as well?

Contributor

cuchac commented Aug 1, 2012

Hi!
Thanks for answer. Hopefully I've fixed both issues.

  1. I've updated English po file.
  2. ugettext_lazy is useful when strings are translated during module load. Therefore I've switched also forms.py to use lazy variant - strings there are also translated in module context. I've left other files intact because lazy variant seems an overkill for normal translations.

@ghost ghost assigned sehmaschine Aug 2, 2012

Owner

sehmaschine commented Aug 2, 2012

thanks – I´ll take a look asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment