My Changes #113

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@angelol

angelol commented Sep 5, 2012

Hi Patrick,

great piece of software, pretty useful. However, I needed to make some changes before it worked for me. I think they might also be useful to others.

  1. When any error occurs during manage.py fb_version_generate, it will still print out "Generating version for file XXX..." without error but no version files will be generated. There is a big try: except: clause around the main routine which catches and hides all errors without message. The correct behaviour would be to stop and print out the exception.

  2. fb_version_generate does not follow symlinks. This explains everything. I think it's very useful and usual in a server environment to use symlinks, so fb_version_generate should be able to work with them.

Cheers,
Angelo

@sehmaschine

This comment has been minimized.

Show comment Hide comment
@sehmaschine

sehmaschine Sep 5, 2012

Owner

thanks. good timing since we´re going to release a new version within the next couple of days.

Owner

sehmaschine commented Sep 5, 2012

thanks. good timing since we´re going to release a new version within the next couple of days.

@ghost ghost assigned sehmaschine Sep 5, 2012

@sehmaschine

This comment has been minimized.

Show comment Hide comment
@sehmaschine

sehmaschine Sep 6, 2012

Owner

fixed in branch stable/3.5.x

Owner

sehmaschine commented Sep 6, 2012

fixed in branch stable/3.5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment