Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Raise exceptions from `functions.version_generator` when in debug #138

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

If you do not have PIL installed correctly and version_generator throws an exception, it is disregarded here, even in when TEMPLATE_DEBUG is True.  This makes it hard to determine why you can't select a different size version in the admin because what is passed back to the image selection window is a blank string.  Re-raising the exception here is helpful for debugging.

@obsoleter obsoleter Raise exceptions on version generation in debug
If you do not have PIL installed correctly and `version_generator` throws an exception, it is disregarded here, even in when `TEMPLATE_DEBUG` is `True`.  This makes it hard to determine why you can't select a different size version in the admin.  What is passed back to the image selection window is a blank string.  Re-raising the exception here is helpful for debugging.
01d252b

@sehmaschine sehmaschine added a commit that referenced this pull request Jan 29, 2013

@sehmaschine sehmaschine templatetag exception, fixed #138 1414c9d

Thanks.

@obsoleter obsoleter closed this Feb 6, 2013

@cuchac cuchac added a commit to cuchac/django-filebrowser that referenced this pull request Mar 1, 2013

@sehmaschine @cuchac sehmaschine + cuchac templatetag exception, fixed #138 9783717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment