Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with python 2.5.* #87

Merged
merged 1 commit into from Feb 11, 2012
Merged

Compatibility issue with python 2.5.* #87

merged 1 commit into from Feb 11, 2012

Conversation

h3
Copy link
Contributor

@h3 h3 commented Feb 10, 2012

I had problem deploying a project on my hosting server today.. after some digging I font the offending line in grappelli's grp_tags:

import json

Problem is that it became a standard library only as python 2.6. So every sites using python 2.5 will break when updating grappelli.

My commit tries to import json but falls back to the simplejson shipped with django if it cannot import it.

While I understand that python is moving forward and 2.5 will be deprecated, suddenly dropping support when 3 lines of codes are required to make it compatible is a bit drastic.

Cheers

@sehmaschine
Copy link
Owner

totally agree – will update to 2.3.7 on the weekend (I didn´t check with 2.5). thanks!

sehmaschine added a commit that referenced this pull request Feb 11, 2012
Compatibility issue with python 2.5.*
@sehmaschine sehmaschine merged commit 2fa0b04 into sehmaschine:master Feb 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants