This repository has been archived by the owner on May 19, 2022. It is now read-only.
SDL2_Mixer configure check is broken #92
Comments
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this issue
Feb 8, 2019
Don't try to check for SDL2_Mixer at configure phase by trying to run program which tries Mix_LoadMUS. First, the program is incorrect as per SDL2_Mixer documentation, one is not allowed to call any SDL2_Mixer functions without first calling Mix_Init() (which is not called). Next, calling any mixer functions may involve opening audio device, which may not be present on the machine where the package is built. Fix by forcing the broken check to pass. PR: 235557 Reported by: jbeich@FreeBSD.org Approved by: portmgr blanket (build fix) Upstream issue: sekaiproject/ponscripter-fork#92 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@492445 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this issue
Feb 8, 2019
Don't try to check for SDL2_Mixer at configure phase by trying to run program which tries Mix_LoadMUS. First, the program is incorrect as per SDL2_Mixer documentation, one is not allowed to call any SDL2_Mixer functions without first calling Mix_Init() (which is not called). Next, calling any mixer functions may involve opening audio device, which may not be present on the machine where the package is built. Fix by forcing the broken check to pass. PR: 235557 Reported by: jbeich@FreeBSD.org Approved by: portmgr blanket (build fix) Upstream issue: sekaiproject/ponscripter-fork#92
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this issue
Feb 8, 2019
Don't try to check for SDL2_Mixer at configure phase by trying to run program which tries Mix_LoadMUS. First, the program is incorrect as per SDL2_Mixer documentation, one is not allowed to call any SDL2_Mixer functions without first calling Mix_Init() (which is not called). Next, calling any mixer functions may involve opening audio device, which may not be present on the machine where the package is built. Fix by forcing the broken check to pass. PR: 235557 Reported by: jbeich@FreeBSD.org Approved by: portmgr blanket (build fix) Upstream issue: sekaiproject/ponscripter-fork#92 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@492445 35697150-7ecd-e111-bb59-0022644237b5
swills
pushed a commit
to swills/freebsd-ports
that referenced
this issue
Feb 9, 2019
Don't try to check for SDL2_Mixer at configure phase by trying to run program which tries Mix_LoadMUS. First, the program is incorrect as per SDL2_Mixer documentation, one is not allowed to call any SDL2_Mixer functions without first calling Mix_Init() (which is not called). Next, calling any mixer functions may involve opening audio device, which may not be present on the machine where the package is built. Fix by forcing the broken check to pass. PR: 235557 Reported by: jbeich@FreeBSD.org Approved by: portmgr blanket (build fix) Upstream issue: sekaiproject/ponscripter-fork#92 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@492445 35697150-7ecd-e111-bb59-0022644237b5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The configure check for SDL2_Mixer is broken. First, the program it uses is incorrect, as it calls
Mix_LoadMUSwithout first callingMix_Init, which is required as per SDL_Mixer documentation. Next, running any mixer functions may lead to opening an audio device, which may not be present on the machine where the package is built (as opposed to the machine where the package is installed and run) which is a common case for automated package builds.I suggest to simplify the check to just compiling test SDL_Mixer program without running it, while in runtime a corresponding message should be displayed if support for required audio formats is missing.
The text was updated successfully, but these errors were encountered: