Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suhosin doesn't build with PHP 5.5 #20

Closed
NewEraCracker opened this issue Jan 27, 2013 · 13 comments
Closed

Suhosin doesn't build with PHP 5.5 #20

NewEraCracker opened this issue Jan 27, 2013 · 13 comments

Comments

@NewEraCracker
Copy link
Contributor

Using Suhosin 0.9.34-dev.

I've posted the build failure log in pastebin at : http://pastebin.com/raw.php?i=pB6etkay

@jasondavis
Copy link

Unfortunately this project seemed to die way back at PHP 5.4.x

@NewEraCracker
Copy link
Contributor Author

Personally I am using Suhosin 0.9.33 in PHP 5.4.12 with a patch I've coded based on input over this bug tracker and changes author has done in 0.9.34-dev.
https://github.com/NewEraCracker/suhosin-patches/tree/master/patches


I've spent sometime today checking PHP 5.5 changes and so far I've produced this patch against 0.9.33
http://pastebin.com/5zLAJW5E

I've haven't tested them yet but at least php builds, please report any issues.

Edit: I found that with the patch provided above phpMyAdmin and Adminer (the scripts I've tested) cause php to crash when patched suhosin extension is enabled. Maybe someone more skilled can review those patches for me and correct the bugs as it seems PHP 5.5 doesn't support the code found at suhosin_execute_internal, especially this line:

retval = ih->handler(IH_HANDLER_PARAM_PASSTHRU);

Thank you.

@stefanesser
Copy link
Collaborator

Suhosin will be PHP 5.5 compatible eventually. There is no need to rush. We are just at Beta 2.

@stefanesser
Copy link
Collaborator

That said: I will most probably be too busy before May to do any work on Suhosin.

@killua-eu
Copy link

Hello Stefan, any news on 5.5 compatibility?

@mathisdt
Copy link

Hello Stefan, could you give a short update on the plans for Suhosin's future? I would very much like to install Suhosin on top of PHP 5.4 / 5.5... Thanks!

@killua-eu
Copy link

Don't want to press this, but is there any way 5.5 compatibility can be achieved? Thanks :)

@NewEraCracker
Copy link
Contributor Author

You can try this patch and report any bugs to myself:
https://github.com/NewEraCracker/suhosin-patches/blob/master/patches/suhosin-0.9.33.php55.diff

Regards,
NewEraCracker

@stefanesser
Copy link
Collaborator

Official suhosin DEV tree is now PHP 5.5 compatible.

@greggles
Copy link

Was that a typo? Did you mean it is no_t_ php 5.5 compatible or that it is no_w_ php 5.5 compatible?

I see some commits like 6f3ba23 and 3142dc0 which imply that it was a typo and that there is active work to make suhosin compatible with php 5.5, which is great news.

Thanks.

@stefanesser
Copy link
Collaborator

Ehmm yes that was a typo.

@calestyo
Copy link

Hey Stefan.... is suhosin now considered production-ready again for the current PHP versions?

@stefanesser
Copy link
Collaborator

Suhosin Extension should be production ready at the end of the week. We will commit some more test case during the week and once that is finished I will release the current version as final.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants