Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix perfs issues #403

Merged
merged 3 commits into from Sep 12, 2012

Conversation

Projects
None yet
2 participants
Contributor

byroot commented Sep 12, 2012

Hi, There is 3 performance related changes.

The most important is that jQuery.data is a very costly call, especially in Firefox. And listening for mousemove events on body, generate a lot of calls. So I've replaced the data access by a simpler and lighter closure variable. http://jsperf.com/data-vs-variable

Also there was 2 useless event delegation handler. In that case regular are suffisant.

Regards.

ivaynberg added a commit that referenced this pull request Sep 12, 2012

@ivaynberg ivaynberg merged commit 2adb8d3 into select2:master Sep 12, 2012

Contributor

ivaynberg commented Sep 12, 2012

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment