Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance SVG check during infinite loop #1

Closed
peter279k opened this issue Jun 12, 2019 · 3 comments
Closed

Enhance SVG check during infinite loop #1

peter279k opened this issue Jun 12, 2019 · 3 comments

Comments

@peter279k
Copy link
Member

I found that it has the infinite loop for checking SVG.

The infinite loop I think it's not proper and I suggest we should set the SplFileObject::eof for the condition.
@peter279k
Copy link
Member Author

peter279k commented Jun 12, 2019 •
edited

@odan, I also found that the SVG image format is generated by XML document.

Perhaps the four bytes are always <svg, and we don't have to use the while loop.

@odan
Copy link
Member

odan commented Jun 12, 2019

This should be fixed now.

@odan odan closed this as completed Jun 12, 2019
@peter279k
Copy link
Member Author

Good. I've looked at the new approach.

Thanks for your concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odan @peter279k